Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix error reporting for prefer-complement #18

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 5, 2018

This PR simplifies and fixes the error reporting for prefer-complement.

Cases with arrow functions, anonymous function expressions, member expressions and call expressions are not covered.


This change is Reviewable

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines         252    249    -3     
=====================================
- Hits          252    249    -3
Impacted Files Coverage Δ
rules/prefer-complement.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6e888...c6e9bd3. Read the comment docs.

Copy link
Member

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lo1tuma lo1tuma merged commit 5c233d0 into ramda:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants