Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to include any parts of tywaves #27

Closed
HakamAtassi opened this issue Jul 7, 2024 · 4 comments · Fixed by #30
Closed

Unable to include any parts of tywaves #27

HakamAtassi opened this issue Jul 7, 2024 · 4 comments · Fixed by #30
Labels
bug Something isn't working internals-chisel The issue is related to the internals of chisel

Comments

@HakamAtassi
Copy link

HakamAtassi commented Jul 7, 2024

I have been able to install and include tywaves into my project using "com.github.rameloni" %% "tywaves-chisel-api" % "0.3.0-SNAPSHOT",

but trying to include

import tywaves.simulator._
import tywaves.simulator.ParametricSimulator._
import tywaves.simulator.simulatorSettings._

has been largely unsuccessful. SBT claims that there is no "simulator" member in tywaves.

@rameloni
Copy link
Owner

rameloni commented Jul 7, 2024

I checked it, it happens when chisel3._ is imported before anything of tywaves.
It happens because of a conflict with the package names of the backend. I'll fix it and push an update in a few days. It is something that shouldn't occur.

For now, I'd recommend moving the import of tywaves before any others. Let me know if this fixes your error.

@rameloni rameloni added bug Something isn't working internals-chisel The issue is related to the internals of chisel labels Jul 7, 2024
@rameloni
Copy link
Owner

rameloni commented Jul 7, 2024

Import sequence causing error.

import chisel._

import tywaves.simulator._
import tywaves.simulator.ParametricSimulator._
import tywaves.simulator.simulatorSettings._

Temporary fix revert order.

import tywaves.simulator._ 
import tywaves.simulator.ParametricSimulator._
import tywaves.simulator.simulatorSettings._ 

import chisel3._

@HakamAtassi
Copy link
Author

Ah yeah that seemed to fix the issue. Glad it was an easy fix. Thanks for the response.

@rameloni rameloni reopened this Jul 8, 2024
@rameloni
Copy link
Owner

rameloni commented Jul 8, 2024

Issue reopened since the error shouldn't happen. Even though it has an easy fix, the user should be able to import chisel and tywaves packages in any order and without any confusion.

The issue will be closed once the package name in chisel3 will be changed and the respective sbt dependency updated.

rameloni added a commit to rameloni/chisel that referenced this issue Jul 9, 2024
Solve any conflict with the package in tywaves-chisel-api.

Fix rameloni/tywaves-chisel#27
rameloni added a commit to rameloni/circt that referenced this issue Jul 9, 2024
rameloni added a commit that referenced this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internals-chisel The issue is related to the internals of chisel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants