This patch allows htmlwidgets to display in pkgdown sites. #404
Conversation
It requires the corresponding branch of downlit and pkgdown to have been installed:
remotes::install_github("dmurdoch/downlit@rglpatch")
remotes::install_github("dmurdoch/pkgdown@rglpatch")
- Add Remotes to DESCRIPTION so the right branches of downlit and pkgdown are loaded.
|
Just merged the pkgdown fix, so once the remotes are updated this should be good to merge. |
DESCRIPTION
Outdated
| rmarkdown, | ||
| testthat | ||
| Enhances: shiny (>= 1.1) | ||
| URL: https://github.com/ramnathv/htmlwidgets | ||
| BugReports: https://github.com/ramnathv/htmlwidgets/issues | ||
| RoxygenNote: 7.1.1 | ||
| Remotes: dmurdoch/downlit@rglpatch, dmurdoch/pkgdown@rglpatch |
There was a problem hiding this comment.
Have these PRs been merged? If so, the Remotes can be updated to point to the main repositories.
|
Yes, they are merged into the devel versions on Github, but not yet on CRAN. I'll change the Remotes field. |
|
The patches to pkgdown and downlit were merged long ago, but a later patch to pkgdown broke things again. The PR to fix the breakage (r-lib/pkgdown#1719) has been languishing there since June. Currently I'm recommending these versions to get things to work: It's quite frustrating how long it's taken to get these PRs merged (including this one, which has been here since March). |
|
I'm going to be focussing the majority of my time on pkgdown and friends for the next few weeks, so I'll push this along as needed. |
|
You can close this; I've incorporated the code into downlit and pkgdown. |
It requires the corresponding branch of downlit and pkgdown to have been installed:
PR's have been sent to those two packages.