Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookups for english words can't find matches when words start with capital letters #95

Closed
Roeekush opened this issue Jul 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Roeekush
Copy link

Hello

I'm trying to set up JL English for a friend.

When JL is looking through an english dictionary, it seems as if capital letters mess it up

Yomitan handles capital letters fine using the same dictionary.

I captured a video to explain this issue better:

chrome_WlTNAubUTS.mp4

I uploaded the English to Japanese dictionary I was using: Vicon_Eng_to_Jp_Dictionary.zip

@rampaa rampaa added enhancement New feature or request wontfix This will not be worked on labels Jul 20, 2024
@rampaa
Copy link
Owner

rampaa commented Jul 20, 2024

JL is intended exclusively for "Japanese -> Any Language" lookups, not for "Any Language -> Any Language" lookups.

Although it is trivial to fix the specific problem you are facing, it's out of JL's scope. For proper lookup support for English, JL would need to find the dictionary form of words (e.g. went -> go), which is, again, out of this project's scope.

@rampaa rampaa closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
@rampaa
Copy link
Owner

rampaa commented Jul 20, 2024

If you can think of a specific case where this would help for "Japanese->Any Language" lookups, I'd be willing to fix this issue.

Something like https://en.wikipedia.org/wiki/List_of_Japanese_Latin_alphabetic_abbreviations comes to mind. But I can't remember ever seeing, for example, "NG" as "ng". If you can think of a Japanese abbreviation in Latin alphabet that is used both in its lower-case and upper-case form for the same meaning, feel free to let me know.

rampaa added a commit that referenced this issue Aug 4, 2024
@rampaa rampaa closed this as completed Aug 4, 2024
@rampaa rampaa removed the wontfix This will not be worked on label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants