Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meris/refactor playable playcontext #305

Merged
merged 30 commits into from
Jul 13, 2022
Merged

Meris/refactor playable playcontext #305

merged 30 commits into from
Jul 13, 2022

Commits on Jun 17, 2022

  1. fix: start refactor

    @merisbahti @marioortizmanero
    merisbahti authored and marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    5e90864 View commit details
    Browse the repository at this point in the history

  2. fix some more refactor

    @merisbahti @marioortizmanero
    merisbahti authored and marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    a6c0654 View commit details
    Browse the repository at this point in the history

  3. fix: it compiles

    @merisbahti @marioortizmanero
    merisbahti authored and marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    62ba63f View commit details
    Browse the repository at this point in the history

  4. More performant version done!

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e43c253 View commit details
    Browse the repository at this point in the history

  5. Almost there

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    cbc1177 View commit details
    Browse the repository at this point in the history

  6. introduce as_borrowed() for id types

    @eladyn @marioortizmanero
    eladyn authored and marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    0f6d439 View commit details
    Browse the repository at this point in the history

  7. fix tests

    @eladyn @marioortizmanero
    eladyn authored and marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    e07a0ed View commit details
    Browse the repository at this point in the history

  8. Rename as_borrowed to as_ref

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b25790a View commit details
    Browse the repository at this point in the history

  9. Fix part of the docs

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    1799615 View commit details
    Browse the repository at this point in the history

  10. Considerably neater implementation

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3f787bb View commit details
    Browse the repository at this point in the history

  11. Fix tests & docs

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    ad36d6a View commit details
    Browse the repository at this point in the history

  12. Back to double-collect join_ids

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    a5fbd25 View commit details
    Browse the repository at this point in the history

  13. Better docs

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    3d68efb View commit details
    Browse the repository at this point in the history

  14. Resolve all that was left 

    * Remove `inline`: https://matklad.github.io/2021/07/09/inline-in-rust.html
* Fix documentation
* Use `into_owned`
    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    5613da3 View commit details
    Browse the repository at this point in the history

  15. Fix tests and string interpolation

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    eb6c1e4 View commit details
    Browse the repository at this point in the history

  16. Webapp example compiles now

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    c50235b View commit details
    Browse the repository at this point in the history

  17. Attempt at generic constructors

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8ae1d22 View commit details
    Browse the repository at this point in the history

  18. Revert parameter to &str

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    2911b0f View commit details
    Browse the repository at this point in the history

  19. Update CHANGELOG

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8da83af View commit details
    Browse the repository at this point in the history

  20. Fix clippy

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    8019a54 View commit details
    Browse the repository at this point in the history

  21. Remove extra clone, as pointed out by @eladyn

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    9d15b04 View commit details
    Browse the repository at this point in the history

  22. Fix tests

    @marioortizmanero
    marioortizmanero committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    ccc0d0d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Merge branch 'master' into meris/refactor-playable-playcontext

    @marioortizmanero
    marioortizmanero authored Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8ba2739 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Fix typo

    @marioortizmanero
    marioortizmanero committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    8689d94 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. Merge branch 'master' into meris/refactor-playable-playcontext

    @marioortizmanero
    marioortizmanero committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    05d8e56 View commit details
    Browse the repository at this point in the history

  2. More tests for to_owned

    @marioortizmanero
    marioortizmanero committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    2796b1e View commit details
    Browse the repository at this point in the history

  3. Fix clippy

    @marioortizmanero
    marioortizmanero committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    a0b47e6 View commit details
    Browse the repository at this point in the history

  4. Use more string formatting capture

    @marioortizmanero
    marioortizmanero committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    0b63f89 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Update CHANGELOG

    @marioortizmanero
    marioortizmanero committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    a75fe44 View commit details
    Browse the repository at this point in the history

  2. Minor improvements

    @marioortizmanero
    marioortizmanero committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    db0d7fa View commit details
    Browse the repository at this point in the history