-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom auth URLs and simplify get
/etc methods
#356
Conversation
dc2ab71
to
cb21a54
Compare
get
/etc methods
@@ -10,6 +10,7 @@ abstract class BaseClient { | |||
ClientResult<()> auto_reauth() | |||
ClientResult<()> refresh_token() | |||
String endpoint_url() | |||
String auth_url() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramsayleung, can you generate the diagram again? Do you know if there's a way to do this automatically instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can regenerate this diagram, but generating the diagram manually is a little clumsy, I would like to figure out how to generate this diagram automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could use this GitHub Action to generate an image from plantuml
file automatically: https://github.com/marketplace/actions/generate-plantuml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Then you can ignore this comment, and we'll set it up in a separate PR.
e205878
to
a759905
Compare
a759905
to
4ffcdff
Compare
4ffcdff
to
4cabf6a
Compare
Note that #375 should be merged before this. |
Everything looks good to me, except for the discussion about how to generate an image file from plantuml file automatically. |
Description
This adds a configurable prefix URL for authentication.
I've also simplified the request methods in the base client. We don't really need
get
if it's only used inendpoint_get
. We can also extendpost_form
toauth_post
, which also prepends the auth URL for convenience, just likeendpoint_get
. Finally, I've renamedendpoint_get
and similars toapi_get
for consistency and because it's clearer and much shorter.Motivation and Context
See #350
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
I've modified the
endpoint_url
test, and added another one forauth_url
.Is this change properly documented?
TODO