Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return new error InvalidToken if user is not yet authenticated #449

Merged

Conversation

har0ke
Copy link

@har0ke har0ke commented Dec 18, 2023

Description

Return new error InvalidToken if user is not yet authenticated. The library should never panic when the user forgets to authenticate, but return a valid error to the user.

Motivation and Context

Resolves #333

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

The library should never panic when the user forgets to authenticate, but
return a valid error to the user.
@ramsayleung
Copy link
Owner

Thanks for your contribution, this CI tasks failed.

@har0ke
Copy link
Author

har0ke commented Dec 19, 2023

Okay, I have fixed the formatting.

@ramsayleung ramsayleung merged commit 8c1d905 into ramsayleung:master Dec 19, 2023
5 checks passed
@ramsayleung
Copy link
Owner

Thanks for your contribution, it's merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientCredsSpotify allows requests before authenticated and panics with 'Rspotify not authenticated'
2 participants