Made fetching earnings_dates faster #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrik-corneliusson
force-pushed
the
dev
branch
from
8f88c9b
to
05f6f66
Compare
Avoid unnecessary request when fetching earnings_date. Added support to limit argument to only fetch as many as needed.
fredrik-corneliusson
force-pushed
the
dev
branch
from
05f6f66
to
0664010
Compare
ValueRaider
reviewed
Nov 20, 2022
ValueRaider
reviewed
Nov 20, 2022
ValueRaider
reviewed
Nov 20, 2022
fredrik-corneliusson
force-pushed
the
dev
branch
from
d4f6253
to
ac60f93
Compare
earnings_history/get_earnings_history was redundant as it was an incomplete implementation of get_earnings_dates().
fredrik-corneliusson
force-pushed
the
dev
branch
from
ac60f93
to
20680b0
Compare
ValueRaider
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary request when fetching earnings_date. Added support to limit argument to only fetch as many as needed.