Fix Yahoo data decryption

[alexa-infra]

Should fix #1291

[SamZhang02]

This seems to work on my local, thanks for the fix :)

[andrewkenreich]

My worry here is you are assuming that the key is just not the other two values in the dict - what if they add another key to that dict eventually? Could we check for the key value that is 128 char long?

Would still break when they change encryption off 128 but prevents if they added future things to the dict not related to this. (Also since you are already preventing if they change the name of this key)

For now though this works. This will probably be a cat and mouse game for awhile.

[ValueRaider]

Restored the "_cr" and "_cs" code path, in case data is coming from requests_cache. And clarified 'data' vs 'stores' naming, was confusing.

[ValueRaider]

@andrewkenreich I've incorporated your feedback, so yfinance should print a useful message if format changes again.

[ValueRaider]

Can I get confirmation that this works with my changes? Then will merge.

[dschaefer]

Worked for me.

[ValueRaider]

Great, merged into dev. Would be great if you can switch to dev and act as beta testers for me, as some other changes there.

dev = I believe is stable but needs stress-testing

[dschaefer]

Already done :). Looks good. Thanks!

[james-stevens]

Well done, great work

If I was doing the code review (which I'm not, so ignore me as you please) I'd say a couple of things

1. probably be neater to make decode_password a separate function (lines 52 to 75)
2. seems to me if k not in ["context", "plugins"]] is vulnerable to breaking, so maybe a function that looks for appropriate looking hex strings might be more robust - but who knows what they will do in the future, so also maybe not

[no0be]

Thanks everyone for the quick fix, just upgraded to the 0.2.4 package from pip3 and I confirm it works fine.

[cameroncochrane]

Thank you for fixing, much appreciated :)

[Sathiya-K]

This seems to work on my local, thanks for the fix :)

Can you please explain how did you fix it? I upgraded my yfinance to 0.1.93. Thanks in advance!

[Sathiya-K]

Thanks everyone for the quick fix, just upgraded to the 0.2.4 package from pip3 and I confirm it works fine.

Upgraded the yfinance library is it?