Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_info usability improvements #1368

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fast_info usability improvements #1368

merged 1 commit into from
Jan 28, 2023

Conversation

ValueRaider
Copy link
Collaborator

@ValueRaider ValueRaider commented Jan 28, 2023

fast_info usability improvements:

  • Add support camelCase dict keys, and officially support these, but secretly continue to also support snake_case keys
  • Add dict functions values() and items()

@ValueRaider ValueRaider mentioned this pull request Jan 28, 2023
@ValueRaider ValueRaider merged commit af5f96f into dev Jan 28, 2023
@ValueRaider ValueRaider deleted the fix/fast-info-camel-case branch January 28, 2023 22:28
@sanyearng
Copy link

I wasn't aware of the following dependency, but am posting here as FYI, as it surprised me:

I could not get Ticker.get_history_metadata() to function unless both a) Ticker.fast_info was first run; and additionally Ticker.fast_info.items() (for 0.2.9)

Delete or ignore this comment if this is otherwise obvious or intended.

@ValueRaider
Copy link
Collaborator Author

ValueRaider commented Jan 29, 2023

Did you should see this message?

RuntimeError: Metadata was never retrieved so far, call history() to retrieve it

It doesn't make sense to request metadata before fetching the real data (e.g. history). If you think something different should happen, request in a new Issue.

@sanyearng
Copy link

Did you should see this message?

RuntimeError: Metadata was never retrieved so far, call history() to retrieve it

It doesn't make sense to request metadata before fetching the real data (e.g. history). If you think something different should happen, request in a new Issue.

Perfect. My mistake.

@ValueRaider ValueRaider mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants