-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace empty list with empty pd.Series #1724
Conversation
I've updated the description. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-picky comments, but IMO every code change should be relevant and matter.
requirements.txt
Outdated
requests_cache==1.1.0 | ||
requests_ratelimiter==0.4.2 | ||
multitasking>=0.0.7 | ||
lxml>=4.9.1 | ||
appdirs>=1.4.4 | ||
pytz>=2022.5 | ||
frozendict>=2.3.4 | ||
beautifulsoup4>=4.11.1 | ||
html5lib>=1.1 | ||
peewee>=3.16.2 No newline at end of file | ||
peewee>=3.16.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the explicit dependencies but kept the newline at the end.
tests/ticker.py
Outdated
@@ -798,7 +814,7 @@ def test_info(self): | |||
def suite(): | |||
suite = unittest.TestSuite() | |||
suite.addTest(TestTicker('Test ticker')) | |||
suite.addTest(TestTickerEarnings('Test earnings')) | |||
#suite.addTest(TestTickerEarnings('Test earnings')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I branched from the wrong base I guess. Reverted.
You might have a better time with Git if you rebase your changes. |
I don't get what happend acutally. I rebased from master to dev and git messed something up. This is the second branch already. I usually don't use rebase because of these issues. Anyway, is there something you request a change for? |
I'll merge this time, but in future:
|
Alright |
Fixes the bug, when you want to perform a pandas operation on an empty list, which is returned when no data is present:
This change does 2 things: