-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Recommendations Trend Summary #1754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing: restore/create unit test
@ValueRaider should I return pandas.Dataframe() ? |
If data is tabular with 2+ rows then Pandas is best, easier to access & analyse. But do this in base.py, I want to work towards separating fetch and format. |
@ValueRaider I can't move creation Dataframe to base, because all other creations are at quote now. We can plan step by step rewrite all code to new version 0.3.0 with code migration and removing old. |
Then for now, format as Pandas in fetch. |
I think, we should separate fetching, parsing and holding. So we will have ticker class as entry point, scrapers for fetching and something in middle for parsing and transforming. |
Final request - squash commits #1084. Keeps history clean. |
added valid modules for quote summary request added _fetch method for fetching quote summary added fetch recommendationTrend
You branched off |
@ValueRaider fixed. Sorry for my bad hands :( |
Add fetching of recommendations as requested from discussion
It's my first pull request (usually i don't write code for other projects, just provide help or code samples ). Tell me, if I am doing something wrong.
For future, i have plans to do some code rewriting, remove stale code, add all avalaible data from yahoo. I have my own project, that recieves more data that this lib.
Fixes #1577