Add error classes for symbol delisting errors, closes #270 #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed test files conform with standards - replaced utcfromtimestamp - replaced utcnow
|
Can you give a simple scenario that is broken? |
|
The issue is that the error messages can't be ignored on a per ticker basis easily. |
ValueRaider
requested changes
Apr 26, 2024
Comment on lines
+12
to
+13
| requests_cache>=1.0 | ||
| requests-ratelimiter>=0.3.1 |
There was a problem hiding this comment.
These are not required to use yfinance. They're optional and README already explains.
Comment on lines
+271
to
+292
| ### Running Tests | ||
|
|
||
| Tests have been written using the built-in Python module `unittest` | ||
|
|
||
| An example of running all tests in a file that calls `unittest.main`: | ||
|
|
||
| ```sh | ||
| python -m unittest tests.test_prices | ||
| ``` | ||
|
|
||
| An example of running a test of a single method (applicable to a class as well): | ||
|
|
||
| ```sh | ||
| python -m unittest tests.test_prices.TestPriceRepair.test_ticker_missing | ||
| ``` | ||
|
|
||
| To run all tests | ||
|
|
||
| ```sh | ||
| python -m unittest discover -s tests | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Best place for this is in Developer Guide #1084 , which already describes running tests.
I'm not seeing any significant behaviour changes. |
|
Cool I'll just maintain my own fork then. |
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes