-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] replace adapter logger with logr interface #1
Conversation
Signed-off-by: Janelle Law <janelle.law@suse.com>
Signed-off-by: Janelle Law <janelle.law@suse.com>
82cf70a
to
6ab56d5
Compare
Signed-off-by: Janelle Law <janelle.law@suse.com>
6b1c35e
to
286b3f7
Compare
I was able to fix the lint issues, but I'm having trouble upgrading the package vulnerabilities. Listed the error and what I've tried below. Any ideas would be much appreciated! Steps I did to make commit 286b3f7, and the govulncheck errors that occurred after pushing the commit:
This resulted in no changes ('nothing to commit, working tree clean'):
This resulted in compile errors due to cadvisor api changes:
|
@jan-law are the vulnerabilities in the dependencies introduced specifically by deps introduced in the updates? Otherwise, this is fine to merge without dependency updates and then we can rebase onto an upstream version that probably has the vulnerabilities fixed. |
We're on a quite "old" version from |
@alexandreLamarre The vulnerabilities aren't related to my changes. They're in a different go module. I can revert my attempt to fix those packages |
The build-package (deb) job fails consistently with the error below. All other jobs besides the govulnchecks are passing.
Is there anything I can do on my end? |
Related #1672
Copy of dbason/opentelemetry-collector-contrib#1
Question - the docker build CI fails on ea68927 with
Running the suggested fix,
go mod tidy
, andgo mod tidy -e
don't produce any changes. All the tests inpkg/stanza
pass withgo test
. The opnisupportagent
tests also pass. What am I missing?