Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rd-networking #108

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Sep 10, 2024

With rancher-sandbox/rancher-desktop#7437 landing we no longer use the files from rancher-desktop-networking; instead, the same tools are built as part of yarn postinstall and appended to the WSL distro tar archive.

With rancher-sandbox/rancher-desktop#7437 landing
we no longer use the files from `rancher-desktop-networking`; instead, the
same tools are built as part of `yarn postinstall` and appended to the WSL
distro tar archive.

Signed-off-by: Mark Yen <mark.yen@suse.com>
jandubois
jandubois previously approved these changes Sep 10, 2024
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

We don't seem to need to adjust for any breaking changes (it seems they're
mostly based on NodeJS version bumps).

Signed-off-by: Mark Yen <mark.yen@suse.com>
@jandubois jandubois merged commit 8668b6c into rancher-sandbox:main Sep 10, 2024
2 checks passed
@mook-as mook-as deleted the remove-networking branch September 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants