Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment profile settings need to be validated #4159

Closed
Tracked by #4608
ericpromislow opened this issue Mar 10, 2023 · 3 comments · Fixed by #4162
Closed
Tracked by #4608

Deployment profile settings need to be validated #4159

ericpromislow opened this issue Mar 10, 2023 · 3 comments · Fixed by #4162
Assignees
Labels
area/deployment Deployment profiles kind/bug Something isn't working regression Functionality was working in a previous release and is now broken
Milestone

Comments

@ericpromislow
Copy link
Contributor

ericpromislow commented Mar 10, 2023

Actual Behavior

The deployment profiles aren't validated.

Steps to Reproduce

Create a default deployment profile like so:

{
 application: {
      pathManagementStrategy: 'geese',
    },
    kubernetes: {
      port: {
        zoo: ['possums', 'snakes', 'otters'],
      },
      enabled: 'fish',
    },
    virtualMachine: {
      memoryInGB: 'cows',
    },
}

Result

The new values end up in the settings

Expected Behavior

Rancher Desktop should complain about the invalid values and refuse to start.

Same with the locked-field thing.

@IsaSih
Copy link
Contributor

IsaSih commented Jun 9, 2023

Regression identified in Mac Intel, build https://github.com/rancher-sandbox/rancher-desktop/actions/runs/5206486035
dep profile with invalid fields used for the test:
user-profile-defaults.txt

@gaktive
Copy link
Contributor

gaktive commented Jun 9, 2023

Working as designed. @IsaSih to retest with different data types.

@IsaSih
Copy link
Contributor

IsaSih commented Jun 9, 2023

Works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deployment Deployment profiles kind/bug Something isn't working regression Functionality was working in a previous release and is now broken
Projects
None yet
4 participants