Do type-based validation on deployment profiles #4612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpromislow
force-pushed
the
4193-registry-profile-improvements
branch
2 times, most recently
from
0c6faec
to
a9bba89
Compare
ericpromislow
force-pushed
the
4159-further-validate-deployment-profiles
branch
3 times, most recently
from
77bda37
to
fae224c
Compare
ericpromislow
force-pushed
the
4193-registry-profile-improvements
branch
5 times, most recently
from
cbfd7bf
to
cf06fdc
Compare
…mprovements Finish reading deployment profiles from the Windows registry
An error occurred while trying to automatically change base from
4193-registry-profile-improvements
to
main
May 12, 2023 21:54
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.7.0 to 0.8.0. - [Commits](golang/sys@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Show the virtiofs option all the time on macOS. Disable it with a tooltip if the system doesn't meet the needed requirement (>= Ventura). Signed-off-by: Tatjana Dehler <tdehler@suse.com>
Experimental settings: show and disable virtiofs option
…rc/go/vtunnel/golang.org/x/sys-0.8.0 Bump golang.org/x/sys from 0.7.0 to 0.8.0 in /src/go/vtunnel
- Don't complain about any entries in the settings schema that aren't in the registry. - Treat `WSL/integrations`, `extensions`, and `diagnostics/mutedChecks` as hashes - Registry keys and value names are case-insensitive - Do type-based parsing of raw registry values. - There's no need to do post-input validation of registry data. The reader validates as it goes. - Convert 0s and 1s in user-defined objects into booleans. Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Extensions are now string:string, not string:bool. So registry values for special objects can be both numeric and strings. Signed-off-by: Eric Promislow <epromislow@suse.com>
…isons. Signed-off-by: Eric Promislow <epromislow@suse.com>
…rror dialogs. Note that types are checked in both the deployment-loader and the settings-validator, but the deployment-loader does simple type-checking, while the settings-validator does some more semantic checking (e.g. ensure some values fall in a range or are in an enumerated list). Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Also fixed a bug that on mac and linux deployment profiles were being created but not deleted. Signed-off-by: Eric Promislow <epromislow@suse.com>
ericpromislow
force-pushed
the
4159-further-validate-deployment-profiles
branch
from
fae224c
to
1300c15
Compare
Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
…rors. Signed-off-by: Eric Promislow <epromislow@suse.com>
|
This PR is obsolete. See PR #4162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4159
Includes adding more unit tests for Windows deployments