Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor postinstall to remove dependency on RD packages #5128

Closed
jandubois opened this issue Jul 7, 2023 · 1 comment · Fixed by #5169
Closed

Refactor postinstall to remove dependency on RD packages #5128

jandubois opened this issue Jul 7, 2023 · 1 comment · Fixed by #5169
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API

Comments

@jandubois
Copy link
Member

jandubois commented Jul 7, 2023 •
edited by adamkpickering
Loading

The current postinstall.ts code imports various @pkg/rancher-desktop like logging and settings.

#5127 is splitting out the part that builds Go binaries because any code that imports our paths package needs a working rdctl paths command, leading to a chicken-and-egg situation.

This issue is about refactoring the rest of post-install to not share code with the application, if possible, to avoid having special-case logic in the app that is really only needed for installation at build time.
@jandubois jandubois added the kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API label Jul 7, 2023
This was referenced Jul 14, 2023
Closed
Merged
@ericpromislow
Copy link
Contributor

Fixed by #5169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Milestone
No milestone
2 participants
@jandubois @ericpromislow