Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Downgrade node-sass to 4.x #141

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Feb 26, 2021

Stratos doesn't yet work with node-sass 5.x, and for some reason having it installed in the parent project breaks Stratos builds. Downgrade to 4.x to have things work.

Note that node-sass 4.x is reported to not work with nodejs 15.x; this means that we will require nodejs 14.x to build.

This is being made as part of #55.

Stratos doesn't yet work with node-sass 5.x, and for some reason having
it installed in the parent project breaks Stratos builds.  Downgrade to
4.x to have things work.

Note that node-sass 4.x is reported to not work with nodejs 15.x; this
means that we will require nodejs 14.x to build.

Signed-off-by: Mark Yen <mark.yen@suse.com>
@mattfarina
Copy link
Contributor

@mook-as we need a plan to make stratos work with more recent node and node-sass.

@mook-as
Copy link
Contributor Author

mook-as commented Mar 3, 2021

Yep, looking at things on the internet, it basically means upgrading packages they use. Will try to do that instead (and make PRs there) in a bit.

@mook-as
Copy link
Contributor Author

mook-as commented Mar 4, 2021

This is basically webpack-contrib/sass-loader#898
That was fixed in sass-loader v10.0.5.

$ npm why sass-loader
sass-loader@10.0.1 dev
node_modules/sass-loader
  sass-loader@"10.0.1" from @angular-devkit/build-angular@0.1002.0
  node_modules/@angular-devkit/build-angular
    dev @angular-devkit/build-angular@"^0.1002.0" from the root project
    @angular-devkit/build-angular@">=0.1000.0 < 0.1100.0" from @angular-builders/custom-webpack@10.0.1
    node_modules/@angular-builders/custom-webpack
      dev @angular-builders/custom-webpack@"^10.0.1" from the root project

So we need to upgrade @angular-devkit/build-angular to something that pulls in sass-loader@10.0.5 or newer; it's currently pinned to 10.0.1.

The newest version in the 10.x line is (currently) v10.2.3, which pulls in sass-loader@10.0.1. This is updated with v11.0.0, which pulls in sass-loader@10.0.5 (i.e. the version we need). I believe this means that we would be able to resolve this by upgrading stratos to angular 11 (angular 12 isn't release yet, I believe).

@mattfarina mattfarina merged commit 2469806 into rancher-sandbox:main Mar 4, 2021
@mook-as mook-as deleted the node-sass-downgrade branch March 4, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants