-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable GuestAgent for RD Networking #4556
Conversation
30e3873
to
7d8959b
Compare
if (this.privilegedServiceEnabled) { | ||
if (rdNetworking) { | ||
guestAgentConfig = { | ||
LOG_DIR: await this.wslify(paths.logs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG_DIR
, GUESTAGENT_KUBERNETES
, etc are all shared between all configs. Would it make sense to build the default map + overrides instead?
Or even merge rdNetworking || this.privilegedServiceEnabled
, and just set GUESTAGENT_PRIVILEGED_SERVICE
differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would make more sense 👍
Signed-off-by: Nino Kodabande <nkodabande@suse.com>
7d8959b
to
b245d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks fine, but I'm having issues testing this (since this looks like it'll have non-obvious effects). When I turn on experimental network tunnel, wsl-init.pid
isn't being written correctly.
That's not exactly requesting changes for this PR, but I can't tell if this would be a good change…
Tested this with both
When
When
When
|
Guest Agent needs to run when the new Rancher Desktop Networking is enabled. It will be used to automate the port forwarding. Guest Agent will be listening for events from k8s, docker, and containerd's event API, upon discovery of the event it will be calling the port forwarding API on the host switch to open appropriate ports.
Related to: rancher-sandbox/rancher-desktop-agent#36
and
#4296