fix: updates extension state if installed/uninstalled from CLI #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scures
force-pushed
the
ops/rdx-refresh-list-uninstall
branch
from
99d3cf1
to
5a1629e
Compare
rak-phillip
requested changes
Jun 27, 2023
|
@rak-phillip I think it's ready for another quick pick, I did some refactor moving the part where we check for the state (installed/uninstalled) to the catalog. |
rak-phillip
requested changes
Jun 29, 2023
| @@ -46,7 +46,7 @@ import { Banner } from '@rancher/components'; | |||
|
|
|||
| import LoadingIndicator from '@pkg/components/LoadingIndicator.vue'; | |||
| import demoMetadata from '@pkg/utils/_demo_metadata.js'; | |||
| import { ipcRenderer } from '@pkg/utils/ipcRenderer'; | |||
| // import { ipcRenderer } from '@pkg/utils/ipcRenderer'; | |||
There was a problem hiding this comment.
We can remove commented imports
|
We merged #5073 to add spell check to CI, so a rebase on top of main might be in order |
Signed-off-by: scures <scurescu@suse.com>
Signed-off-by: scures <scurescu@suse.com>
Signed-off-by: scures <scurescu@suse.com>
Signed-off-by: scures <scurescu@suse.com>
Signed-off-by: scures <scurescu@suse.com>
scures
force-pushed
the
ops/rdx-refresh-list-uninstall
branch
from
bacefb6
to
bd2eaad
Compare
rak-phillip
requested changes
Jul 5, 2023
Signed-off-by: scures <scurescu@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4951
Updates the extension state using
ipcRenderer