-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay starting the server API until the config has been loaded. #5104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Slack discussion, we're leaning towards changing things so the HTTP server only starts after the settings have completed loading (with all the checks) instead.
2c1d4b9
to
05eac06
Compare
Running this command while starting up RD: while : ; do
echo list-settings
./resources/darwin/bin/rdctl list-settings
echo $?
sleep 0.1
echo api settings
./resources/darwin/bin/rdctl api settings
echo $?
sleep 0.1
echo put settings
./resources/darwin/bin/rdctl api /settings -X PUT -b '{"version": 9, "kubernetes": {"version": "moo"}}'
echo $?
sleep 0.1
echo extension install
./resources/darwin/bin/rdctl extension install beeker
echo $?
sleep 0.1
done
I get this output, where the result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but there's a rebased copy of #5098 in the log. Please rebase on main
and we can merge.
* 05eac06083e5382cc0301f1424e73f81b7826dc5 (pr/5104/head, origin/5099-flag-premature-requests) Verify that settings have been loaded before servicing API requests involving them.
* 4a1f4b104ba279c7bf2562988bd41e4f73dd77bb RDX: Expose API to main window
| * 120c0a1074063e427e47a440cdb7d332ef540efa (origin/main) Merge pull request #5098 from mook-as/extensions/expose-to-app
|/|
| * df2a2f0ef11630755dc2d8f33bc7f5978b0b5064 (pr/5098/head, extensions/expose-to-app) RDX: Expose API to main window
* | dc2a7b7a5a632c3386118c789af3798bf852c138 Merge pull request #5103 from jandubois/merge-1.9.1
…nvolving them. Many of the http commands rely on having a loaded config, so we don't lose much by waiting. Signed-off-by: Eric Promislow <epromislow@suse.com>
05eac06
to
1f7c511
Compare
Done... |
See rancher-sandbox#5104 So we don't need to check the output of `rdctl api /settings` for it anymore. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
See rancher-sandbox#5104 So we don't need to check the output of `rdctl api /settings` for it anymore. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
See rancher-sandbox#5104 So we don't need to check the output of `rdctl api /settings` for it anymore. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
See rancher-sandbox#5104 So we don't need to check the output of `rdctl api /settings` for it anymore. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Fixes #5099