E2E: Don't package logs in GitHub CI #5598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only needed the tar file because CirrusCI only supported single-file uploads; GitHub is set to upload the whole directory. This avoids the use of tar on Windows, which is having issues with file permissions (the log files are in use). Signed-off-by: Mark Yen <mark.yen@suse.com>
mook-as
force-pushed
the
e2e/github-windows/logs-error
branch
from
e5ba54a
to
e5a1872
Compare
IsaSih
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only needed the tar file because CirrusCI only supported single-file uploads; GitHub is set to upload the whole directory. This avoids the use of tar on Windows, which is having issues with file permissions (the log files are in use).