Guard a possibly null pathManager. #6179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
reviewed
Dec 12, 2023
If the 'settings-update' event is handled before settings are loaded, `pathManager` could be null. Also, extract initializing `pathManager` into a function. - This happens from both changing a pref (any pref) in the first-run window, as well as during normal settings loading. Note that from first-run we're calling `pathManager.enforce()`, while from standard startup we're calling `integrationManager.enforce()` If there's a problem here, it should be covered in a separate issue and PR. Signed-off-by: Eric Promislow <epromislow@suse.com>
ericpromislow
force-pushed
the
guard-null-strategy
branch
from
79f6616
to
8261886
Compare
mook-as
approved these changes
Dec 13, 2023
Comment on lines
+300
to
+302
| if (pathManager) { | ||
| await pathManager.remove(); | ||
| } |
There was a problem hiding this comment.
Is that the same as
Suggested change
| if (pathManager) { | |
| await pathManager.remove(); | |
| } | |
| await pathManager?.remove(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the 'settings-update' event is handled before settings are loaded at startup,
pathManagercould be null.This happens when the first-run dialog happens before settings have been loaded.