win-ca: Fix importing CAs from system #6199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use dotAll flag on the RE to find end of certificates - Emit any extra data at the end of the cert list (even though it is likely to be empty) Signed-off-by: Mark Yen <mark.yen@suse.com>
jandubois
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
I haven't tested it, but the code change looks good. But I think only the dotAll flag is really necessary; I don't understand the point of emitting additional data at the end that isn't a well-formed cert. I expect it will either be ignored by the consumer, or throw an error there...
|
Yeah, only the dotAll is needed. Invalid certs just print a warning, but since there's a chance we missed something printing the rest still means we can potentially recover bits. I should have based this on release-1.12 branch… ah well, cherry-pick it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6198