Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TypeScript to 5.4.5 #7012

Merged

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Jun 6, 2024

This bumps TypeScript to the newest available.

Note that type checking in yarn dev is currently kind of broken, due to TypeStrong/fork-ts-checker-webpack-plugin#845.

This is still producing errors.

Signed-off-by: Mark Yen <mark.yen@suse.com>
With the TypeScript bump, things that depend on TypeScript version needs to
be bumped too.

Signed-off-by: Mark Yen <mark.yen@suse.com>
Copy link
Contributor Author

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to update dependabot configs:

- # TypeScript bumping has issues with our code right now.
# See https://github.com/microsoft/TypeScript/issues/56628
dependency-name: "typescript"
update-types: [ "version-update:semver-major" ]

Since we bumped TypeScript manually, we no longer need to prevent
dependabot from bumping it further.

Signed-off-by: Mark Yen <mark.yen@suse.com>
@mook-as mook-as linked an issue Jun 6, 2024 that may be closed by this pull request
@gunamata gunamata requested a review from Nino-K June 7, 2024 16:50
@Nino-K Nino-K merged commit 6eb4d13 into rancher-sandbox:main Jun 13, 2024
15 checks passed
@mook-as mook-as deleted the dependabot/npm_and_yarn/typescript-5.4.5 branch July 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump TypeScript to v5
2 participants