build(deps-dev): bump electron-builder from 24.13.3 to 25.0.5

[dependabot]

Bumps electron-builder from 24.13.3 to 25.0.5.

Release notes

Sourced from electron-builder's releases.

v25.0.5

What's Changed

• fix: windows signature verification special chars by @​ckarich in electron-userland/electron-builder#8409
• fix: change abort to aborted event by @​beyondkmp in electron-userland/electron-builder#8282
• chore(deps): upgrade semver to latest to resolve CVE by @​beyondkmp in electron-userland/electron-builder#8417
• fix: Snap publish regression by @​lutzroeder in electron-userland/electron-builder#8424
• chore(deploy): Release by @​github-actions in electron-userland/electron-builder#8411

New Contributors

• @​ckarich made their first contribution in electron-userland/electron-builder#8409

Full Changelog: electron-userland/electron-builder@v25.0.4...v25.0.5

v25.0.4

What's Changed

• fix(electron-updater,deb): Handle spaces in application artifact name for deb by @​Ryan432 in electron-userland/electron-builder#8400
• feat: unpacked native node file by @​beyondkmp in electron-userland/electron-builder#8392
• feat: add custom channel in github provider by @​beyondkmp in electron-userland/electron-builder#8393
• fix: add disableDefaultIgnoredFiles option by @​beyondkmp in electron-userland/electron-builder#8398
• fix: return parent dir for local dependency by @​beyondkmp in electron-userland/electron-builder#8406
• fix: handle spaces in artifact name for all linux platforms instead of only .deb by @​xyloflake in electron-userland/electron-builder#8403
• docs: Fix a broken link formatting in the docs by @​mokagio in electron-userland/electron-builder#8407
• chore(deploy): Release by @​github-actions in electron-userland/electron-builder#8402

New Contributors

• @​Ryan432 made their first contribution in electron-userland/electron-builder#8400
• @​xyloflake made their first contribution in electron-userland/electron-builder#8403
• @​mokagio made their first contribution in electron-userland/electron-builder#8407

Full Changelog: electron-userland/electron-builder@v25.0.3...v25.0.4

v25.0.3

What's Changed

• fix: delete the symlink file when the target is empty by @​beyondkmp in electron-userland/electron-builder#8371
• fix: Add global download promise to limit concurrent downloads to 1 by @​s77rt in electron-userland/electron-builder#8378
• chore: update outdated docs for vite by @​gweesin in electron-userland/electron-builder#8379
• fix: upgrade app-builder-bin with downgraded appimage tool by @​mmaietta in electron-userland/electron-builder#8387
• fix(windows,code-sign): cannot sign binary files in Github Actions by @​BlackHole1 in electron-userland/electron-builder#8384
• chore(deploy): Release by @​github-actions in electron-userland/electron-builder#8377

New Contributors

• @​s77rt made their first contribution in electron-userland/electron-builder#8378
• @​gweesin made their first contribution in electron-userland/electron-builder#8379

Full Changelog: electron-userland/electron-builder@v25.0.2...v25.0.3

v25.0.2

What's Changed

• fix: adding additional logging when importing/requiring a hook script by @​mmaietta in electron-userland/electron-builder#8356
• chore(deps): update dependency mkdocs to <1.7 by @​renovate in electron-userland/electron-builder#8350

... (truncated)

Changelog

Sourced from electron-builder's changelog.

25.0.5

Patch Changes

• Updated dependencies [8e6c1712]:
  • app-builder-lib@25.0.5
  • dmg-builder@25.0.5

25.0.4

Patch Changes

• Updated dependencies [12c52a81, f7daeb99, 5ab2bee1]:
  • app-builder-lib@25.0.4
  • dmg-builder@25.0.4

25.0.3

Patch Changes

• Updated dependencies [f8fbdd12, afd81326, 553c737b]:
  • app-builder-lib@25.0.3
  • builder-util@25.0.3
  • dmg-builder@25.0.3

25.0.2

Patch Changes

• #8372 c85b73d7 Thanks @​mmaietta! - fix: allow enabling tsc lib checking on electron-updater package

• Updated dependencies [2541eb62, 2acdf65d, c85b73d7, 54c1059b, 2a0ea65c]:

  • app-builder-lib@25.0.2
  • builder-util@25.0.2
  • dmg-builder@25.0.2

25.0.1

Patch Changes

• Updated dependencies [372b046b, 089dd639, 578a7e1a]:
  • app-builder-lib@25.0.1
  • builder-util@25.0.1
  • dmg-builder@25.0.1

25.0.0

Minor Changes

• #8150 f4e6ae29 Thanks @​mmaietta! - feat: add functionality to just publish artifacts

... (truncated)

Commits

• d5d9f3f chore(deploy): Release v25.0.5 (electron-updater@6.3.4) (#8411)
• de1ea75 Revert "feat: allow riscv64 support via custom electron dist (#8143)" (#8427)
• b306895 feat: allow riscv64 support via custom electron dist (#8143)
• 1dcf6bc chore(deploy): Release v25.0.4 (electron-updater@6.3.3) (#8402)
• 84f2909 chore(deploy): Release v25.0.3 (electron-updater@6.3.2) (#8377)
• b20496b chore(deploy): Release v25.0.2 (electron-updater@6.3.1) (#8357)
• c85b73d fix: allow typescript typechecking for electron-updater .d.ts (#8372)
• fb16669 chore(deploy): Release v25.0.1 (#8343)
• bfe4ecc chore(deploy): Release v25.0.0 (electron-updater@6.3.0) (#8337)
• 1320c0e chore(deploy): Release v25.0.0-alpha.13 (electron-updater@6.3.0-alpha.8) (alp...
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[jandubois]

Electron Builder 25 requires Node 20; we can't upgrade as long as we are on Node 18.

[mook-as]

Current failure is because, per https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation:

Important

Python >= v3.12 requires node-gyp >= v10

$ yarn why node-gyp
…
=> Found "node-gyp@10.2.0"
…
=> Found "@electron/rebuild#node-gyp@9.4.1"
info This module exists because "electron-builder#app-builder-lib#@electron#rebuild" depends on it.

https://github.com/electron/rebuild/blob/cb372cdf09d9ca3ac8f1231608e4ebedddabe51c/package.json#L50
electron/rebuild#1116
I tried overriding it with resolutions, but that just makes node node_modules/electron-builder/out/cli/cli.js install-app-deps hang (according to CI, on Linux & macOS).

Trying to manually run pip install setuptools seems better, but now on Linux (only) we get:

  • electron-builder  version=25.0.5
  • executing @electron/rebuild  electronVersion=30.5.1 arch=x64 buildFromSource=false appDir=./
  • installing native dependencies  arch=x64
  • preparing       moduleName=fs-xattr arch=x64
  • finished        moduleName=fs-xattr arch=x64
  • preparing       moduleName=native-reg arch=x64
  ⨯ node:internal/modules/cjs/loader:1228
  throw err;
  ^

Error: Cannot find module 'node-addon-api'
Require stack:
- /home/runner/work/rd/rd/node_modules/native-reg/[eval]
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at [eval]:1:1
    at runScriptInThisContext (node:internal/vm:209:10)
    at node:internal/process/execution:118:14
    at [eval]-wrapper:6:24
    at runScript (node:internal/process/execution:101:62)
    at evalScript (node:internal/process/execution:133:3) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/home/runner/work/rd/rd/node_modules/native-reg/[eval]' ]
}

Node.js v20.17.0
gyp: Call to 'node -p "require('node-addon-api').gyp"' returned exit status 1 while in binding.gyp. while trying to load binding.gyp
Error: `gyp` failed with exit code: 1
    at ChildProcess.onCpExit (/home/runner/work/rd/rd/node_modules/@electron/rebuild/node_modules/node-gyp/lib/configure.js:325:16)
    at ChildProcess.emit (node:events:519:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)


  ⨯ node-gyp failed to rebuild '/home/runner/work/rd/rd/node_modules/native-reg'  failedTask=installAppDeps stackTrace=Error: node-gyp failed to rebuild '/home/runner/work/rd/rd/node_modules/native-reg'
    at ChildProcess.<anonymous> (/home/runner/work/rd/rd/node_modules/@electron/rebuild/lib/module-type/node-gyp/node-gyp.js:118:24)
    at ChildProcess.emit (node:events:519:28)
    at ChildProcess._handle.onexit (node:internal/child_process:294:12)
POSTINSTALL ERROR:  {"code":1,"signal":null,"message":"Command failed: node node_modules/electron-builder/out/cli/cli.js install-app-deps"}
error Command failed with exit code 2.

It looks like this was also ready installed on macOS, because:

$ yarn why node-addon-api
…
info Reasons this module exists
   - "dmg-license#iconv-corefoundation" depends on it
   - Hoisted from "dmg-license#iconv-corefoundation#node-addon-api"

After that, it's just stuff we're importing from them that needs updating; that's more of the normal kind of upgrade failures.

---

After that, we end up with something weird:

$ node scripts/ts-wrapper.js scripts/package.ts
/home/runner/work/rd/rd/node_modules/app-builder-lib/src/winPackager.ts:38
export class WinPackager extends PlatformPackager<WindowsConfiguration> {
                                 ^
TypeError: Class extends value undefined is not a constructor or null
    at Object.<anonymous> (/home/runner/work/rd/rd/node_modules/app-builder-lib/src/winPackager.ts:38:34)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Object.require.extensions.<computed> [as .js] (/home/runner/work/rd/rd/node_modules/ts-node/src/index.ts:1608:43)

Both classes are part of app-builder-lib, so it shouldn't be an issue of mismatched versions. It sounds like electron-userland/electron-builder#8431 which says develar/app-builder#134 would fix it, but forcing app-builder-bin@5.0.0-alpha.9 just ends up with a stack overflow for some reason.

[mook-as]

Given podman-desktop/podman-desktop#8806 I suspect we should just look at the next bump of electron-builder instead.

[mook-as]

@dependabot recreate

It looks like they're up to 25.1.7 now, let's see if that is happier

[mook-as]

25.1.7 is in pre-release (tagged as next in npm), so dependabot isn't seeing it. Also, it didn't seem to help anyway.

[jandubois]

Thanks, LGTM.

I wonder though if we should put the combination of setup-python, install setuptools, yarn install into a reusable action in .github/actions.

I'll leave it to you if you think that's worth it, or if you want to merge as-is.

[mook-as]

I'll merge it as-is, and do a follow-up to see what cleanup we can do.