Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed github.com/gogo/protobuf #7492

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Removed github.com/gogo/protobuf #7492

merged 1 commit into from
Sep 17, 2024

Conversation

Nino-K
Copy link
Member

@Nino-K Nino-K commented Sep 17, 2024

This commit updates the protobuf package from github.com/gogo/protobuf to google.golang.org/protobuf. This migration appears to resolve the panic issue in guestAgent.

Fixes: #7491

@Nino-K Nino-K requested a review from mook-as September 17, 2024 00:06
mook-as
mook-as previously approved these changes Sep 17, 2024
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but not auto-merged; Nino mentioned that he'd like to run a BATS run to make sure the traefik test passes before merging. (But there's no reason to end up blocking the merge once that succeeds.)

This commit updates the protobuf package from
`github.com/gogo/protobuf` to `google.golang.org/protobuf`.
This migration appears to resolve the panic issue in guestAgent.

Signed-off-by: Nino Kodabande <nkodabande@suse.com>
@Nino-K Nino-K merged commit 3a8a4fc into main Sep 17, 2024
28 checks passed
@Nino-K Nino-K deleted the change-gogo-protobuf branch September 17, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GuestAgent panics
2 participants