Upgrade to NodeJS 20 #7537
Merged
Upgrade to NodeJS 20 #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already using it as part of Electron Signed-off-by: Mark Yen <mark.yen@suse.com>
The latter has been replaced by the former when using jest 27+, and we are already installing it (but not using it?); we needed to bump vue-jest because it pulls in a dependency (deasync) on Windows that would have required the use of node-gyp (but @vue/vue2-jest no longer requires). We also need to bump @vue/vue2-jest as the old version wanted something in ts-jest that did not exist in ts-jest 28+ Signed-off-by: Mark Yen <mark.yen@suse.com>
Node has changed the error messages around JSON parsing so that it returns better details about the encountered errors; update the test expectations to match the new strings. Signed-off-by: Mark Yen <mark.yen@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the NodeJS version we use (for building etc.) to 20.
Note that Electron already ships with Node 20; so runtime is unaffected.
Reviewing commit-by-commit (and reading the commit messages) is recommended.
Fixes #7444