Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3sHelper: k3s channels: Allow channel instead of channels #7905

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Dec 9, 2024

It looks like a server-side change had made this possibly singular instead of plural. Accept both so we can take whichever the server happens to present.

Fixes #7904 (if there are no other reasons for it).

It looks like a server-side change had made this possibly singular instead
of plural.  Accept both so we can take whichever the server happens to
present.

Signed-off-by: Mark Yen <mark.yen@suse.com>
@mook-as mook-as requested a review from jandubois December 9, 2024 22:45
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois enabled auto-merge December 9, 2024 22:48
@jandubois jandubois merged commit 16e8bbe into rancher-sandbox:main Dec 9, 2024
20 checks passed
@mook-as mook-as deleted the k3s/channel-resource-type branch December 13, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E failures in CI
2 participants