Windows: call runtime.LockOSThread in network-setup
#8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If debug mode is set, we enable debug logging for wsl-init (and therefore network-setup). Signed-off-by: Mark Yen <mark.yen@suse.com>
We're doing some namespace jiggling; sometimes it seems like we can end up in the wrong namespace (where we fail to configure the veth pair for veth-rd-ns), and it's in a situation where veth-rd-wsl is visible. Assuming this is because we've jumped OS threads due to golang green thread scheduling issues, try to lock the OS thread to mitigate the issue. Signed-off-by: Mark Yen <mark.yen@suse.com>
jandubois
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing Windows E2E test failures intermittently in #7939 along the lines of failed setting up veth: veth-rd-ns for rancher desktop namespace: Link not found. I think this is happening because we got our threads switched out some time between creating the new namespace (and switching to it) and trying to use that link name.
Note that this is actually all documented in the
netnsmodule.This also has a commit to enable debug logging for
network-setupwhen the application-global debug flag is enabled.