This repository has been archived by the owner on Jun 18, 2022. It is now read-only.
add version ability #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@StrongMonkey I don't quite see what this accomplishes. I think we are looking for something more like https://github.com/rancher/rancher-net/blob/master/main.go#L19 |
StrongMonkey
force-pushed
the
get-version
branch
from
288e173 to
fadd173
Compare
|
@ibuildthecloud changed. |
| func main() { | ||
| if len(os.Args) > 1 { |
There was a problem hiding this comment.
You shouldn't check the length. Just make the flag a global and make it a bool flag. If some body runs agent -version then the value of the bool flag will be true and then you print the version and exit.
StrongMonkey
force-pushed
the
get-version
branch
2 times, most recently
from
abadac7 to
ec18907
Compare
StrongMonkey
force-pushed
the
get-version
branch
from
ec18907 to
f7167cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.