Improve NetworkProfile configuration #29
Conversation
pkg/aks/create.go
Outdated
| } else { | ||
| // Network Policy Azure can be used only with Network Plugin Azure CNI | ||
| if containerservice.NetworkPolicy(to.String(spec.NetworkPolicy)) == containerservice.NetworkPolicyAzure { | ||
| networkProfile.NetworkPolicy = containerservice.NetworkPolicyCalico |
There was a problem hiding this comment.
I don't think it's good practice to silently change a configured value behind the user's back like this. It should either be validated and an error returned to let the user correct it, or even just pass the invalid config to AKS and bubble up the error from there.
There was a problem hiding this comment.
@cmurphy This is fixing an issue with AKSv2 provisioning where the network configuration is not being set properly so the cluster gets deployed with no network policy enabled and the kubenet network plugin regardless of the options you select in the UI.
As for silently changing a configured value, I agree that it should be validated and rejected with an error or bubble up AKS' error since the UI has logic to make sure you can't select the Azure network policy without the Azure CNI already.
There was a problem hiding this comment.
Comments included, thank you
mjura
force-pushed
the
master-plugin
branch
2 times, most recently
from
41def04
to
80fec30
Compare
No description provided.