Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7] ci: Specify the exact tag for the new release #600

Merged

Conversation

yiannistri
Copy link
Contributor

What this PR does / why we need it:

Specify the exact tag for the new release. This is necessary because by default, goreleaser sorts tags by name before selecting which tag to release, which causes problems when >1 tags point to the same commit (un-rc process). From https://goreleaser.com/cookbooks/set-a-custom-git-tag/

Which issue(s) this PR fixes
Issue #596

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

… default, goreleaser sorts tags by name which causes problems when >1 tags point to the same commit (un-rc process).
@yiannistri yiannistri marked this pull request as ready for review July 22, 2024 13:38
@yiannistri yiannistri requested a review from a team as a code owner July 22, 2024 13:38
@yiannistri yiannistri merged commit b085e75 into rancher:release-v2.7 Jul 22, 2024
6 checks passed
@yiannistri yiannistri deleted the 596-multiple-tags-release-v2.7 branch July 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants