Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for UIPlugin resources in default ResourceSet #508

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jbiers
Copy link
Member

@jbiers jbiers commented Jul 23, 2024

This PR seeks to resolve issue #483

Test Steps

  • In a local cluster with the Kamaji UI extension installed, manually edited the default ResourceSet to include the new rule for UIPlugins.
  • Took a backup (B1)
  • See if B1 correctly includes the Kamaji UIPlugin
  • Create a new cluster and restore the backup as detailed here
  • Once restored, enable extensions in the new cluster and reload the page. Check if Kamaji UI remains correctly installed.

@jbiers jbiers requested a review from ericpromislow as a code owner July 23, 2024 15:01
@jbiers jbiers requested a review from mallardduck July 23, 2024 15:01
@mallardduck mallardduck added this to the v2.9-Next2 milestone Jul 23, 2024
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; wonder if namespace part matters though.
Not sure we ever see any outside that namespace.
But maybe only gathering ones we know we use today is fine and if it changes later we add more. Rather than having to restrict things more later because we backup and restore too much?

@jbiers jbiers merged commit 1f669c9 into rancher:release/v5.0 Jul 24, 2024
3 checks passed
@jbiers jbiers deleted the backup-uiplugin-resources branch July 24, 2024 13:46
@jbiers jbiers restored the backup-uiplugin-resources branch July 24, 2024 13:55
@jbiers jbiers deleted the backup-uiplugin-resources branch July 24, 2024 13:55
@mallardduck
Copy link
Member

/backport v2.8-Next2 release/v4.0

@mallardduck
Copy link
Member

/backport v2.7-Next2 release/v3.0

Copy link

Not creating port issue, milestone v2.7-Next2 does not exist or is not an open milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants