Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport v2.8-Next2] Add rule for UIPlugin resources in default ResourceSet #509

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[backport v2.8-Next2] Add rule for UIPlugin resources in default ResourceSet #509

merged 1 commit into from
Jul 31, 2024

Conversation

github-actions[bot]
Copy link

This is an automated request to port PR #508 by @mallardduck

Original PR body:

This PR seeks to resolve issue #483

Test Steps

  • In a local cluster with the Kamaji UI extension installed, manually edited the default ResourceSet to include the new rule for UIPlugins.
  • Took a backup (B1)
  • See if B1 correctly includes the Kamaji UIPlugin
  • Create a new cluster and restore the backup as detailed here
  • Once restored, enable extensions in the new cluster and reload the page. Check if Kamaji UI remains correctly installed.

@github-actions github-actions bot requested a review from a team as a code owner July 24, 2024 14:01
@github-actions github-actions bot added this to the v2.8-Next2 milestone Jul 24, 2024
ericpromislow
ericpromislow approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mallardduck mallardduck merged commit fdc7215 into release/v4.0 Jul 31, 2024
@mallardduck mallardduck deleted the gha-portpr-10078092867-1 branch October 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.8-Next2
Development

Successfully merging this pull request may close these issues.
3 participants
@ericpromislow @mallardduck @jbiers