Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s 1.29. #467

Merged

Conversation

ericpromislow
Copy link
Collaborator

The encryption getter now wants an APIServerID, but this field is currently used only for metrics, so we can pass an empty string.

@ericpromislow ericpromislow requested a review from mallardduck May 9, 2024 21:52
The encryption getter now wants an APIServerID, but this field is currently used only for metrics,
so we can pass an empty string.
@ericpromislow ericpromislow force-pushed the 44097-bump-k8s-to-1-29-3 branch 2 times, most recently from a289d4e to b10dff2 Compare May 13, 2024 17:37
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note.

pkg/util/util.go Outdated Show resolved Hide resolved
@ericpromislow ericpromislow force-pushed the 44097-bump-k8s-to-1-29-3 branch from b10dff2 to 8f12f25 Compare May 13, 2024 18:11
@ericpromislow ericpromislow requested a review from mallardduck May 13, 2024 18:11
@ericpromislow ericpromislow merged commit e20ad24 into rancher:release/v5.0 May 13, 2024
3 checks passed
github.com/rancher/wrangler v1.0.2
github.com/rancher/wrangler/v2 v2.1.4
github.com/rancher/lasso v0.0.0-20240424194130-d87ec407d941
github.com/rancher/wrangler v1.1.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed wrangler was downgraded from v2 to v1? Is there a particular reason why there? Seems odd for 1.29 k8s support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants