Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump k8s to 1.30 #478

Merged
merged 3 commits into from
Jun 28, 2024
Merged

bump k8s to 1.30 #478

merged 3 commits into from
Jun 28, 2024

Conversation

ericpromislow
Copy link
Collaborator

Related to issue rancher/rancher#45339

@ericpromislow ericpromislow requested review from alexandreLamarre and a team May 31, 2024 21:55
@ericpromislow ericpromislow force-pushed the 45339-bump-k8s-to-1.30 branch from c7a3db1 to 824c3a1 Compare May 31, 2024 21:56
@ericpromislow ericpromislow requested a review from a team June 4, 2024 16:38
@ericpromislow ericpromislow requested a review from a team June 5, 2024 22:32
@ericpromislow ericpromislow requested a review from a team June 6, 2024 20:48
@mallardduck
Copy link
Member

I'll test and review this sometime later today triage time permitting.
Otherwise I'll test this tomorrow unless someone beats me to it.

mallardduck
mallardduck requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing.

I also was unsure about the goreleaser changes too - guess we don't really need to publish windows or mac binaries so that's fine.

.github/renovate.json Outdated Show resolved Hide resolved
@ericpromislow ericpromislow force-pushed the 45339-bump-k8s-to-1.30 branch from 824c3a1 to f54479e Compare June 18, 2024 23:44
mallardduck
mallardduck approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mallardduck mallardduck requested review from joshmeranda and removed request for alexandreLamarre June 28, 2024 17:40
joshmeranda
joshmeranda approved these changes Jun 28, 2024
View reviewed changes
Copy link

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpromislow ericpromislow merged commit a9ca889 into rancher:release/v5.0 Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeranda joshmeranda joshmeranda approved these changes

@mallardduck mallardduck mallardduck approved these changes

@alexandreLamarre alexandreLamarre alexandreLamarre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericpromislow @mallardduck @joshmeranda @alexandreLamarre