[GHA] Reduce jobs on tag publish and fix tag var/context #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...just noticed the GHA job that ran after I added this fix has the value empty. read the docs harder on GH and found out I read the wrong docs and mixed env var and context. this changes it to use a valid context within the GHA
alexandreLamarre
approved these changes
Jul 19, 2024
ericpromislow
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 important things:
Why those matter:
Reducing GHA jobs
There are a lot of instances where varying rancher repos are failing due to odd rate-limit things and other quirks. Eventually these will be ironed out, but until then we can reduce the load we put on it by making this change. Since both the workflows rely on the same "pre-step" and call the CI workflow - that spawns 2 instances of CI with 3 jobs each, for 6 jobs total. And if one half of those fail/pass then the other should too (sans GHA worker issues).
Fix to last attempt to multiple tags on identical commit
I misread the GHA docs and was looking at references for ENV based variables that are provided. However used an incorrect syntax and as a result the value was empty when reviewing the job. So that confirms my suspicion that the issue could have come back at next un-RC. By using the
githubcontext though I can get the results I was going for with the first version of the fix.