-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a wizard to create infrastructure provider #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantis-toboggan-md
requested changes
Feb 5, 2024
Credentials mapping is not available by BE yet, so the missing variable error is currently expected. |
mantis-toboggan-md
requested changes
Feb 15, 2024
eva-vashkevich
force-pushed
the
provider
branch
from
February 15, 2024 20:43
709381a
to
52be9e7
Compare
mantis-toboggan-md
requested changes
Apr 10, 2024
pkg/capi/edit/turtles-capi.cattle.io.capiprovider/ProviderConfig.vue
Outdated
Show resolved
Hide resolved
pkg/capi/edit/turtles-capi.cattle.io.capiprovider/ProviderConfig.vue
Outdated
Show resolved
Hide resolved
pkg/capi/edit/turtles-capi.cattle.io.capiprovider/ProviderConfig.vue
Outdated
Show resolved
Hide resolved
pkg/capi/edit/turtles-capi.cattle.io.capiprovider/ProviderConfig.vue
Outdated
Show resolved
Hide resolved
mantis-toboggan-md
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13
Added a wizard to create infrastructure provider.
Need to clarify with the BE what to do in the case of a custom provider and how to handle required variables ie for aws.