Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed name validation, fixed vsphere case #54

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fixed name validation, fixed vsphere case #54

merged 1 commit into from
Apr 25, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Apr 25, 2024 •
edited
Loading

mantis-toboggan-md
mantis-toboggan-md approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 634a7a6 into rancher:main Apr 25, 2024
@eva-vashkevich eva-vashkevich deleted the iss52 branch April 25, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantis-toboggan-md mantis-toboggan-md mantis-toboggan-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to update name validation when creating a cluster to match rules from the Backend
2 participants
@eva-vashkevich @mantis-toboggan-md