Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Made version field required for custom provider #72

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[FIX] Made version field required for custom provider #72

merged 1 commit into from
Jul 22, 2024

Conversation

eva-vashkevich
Copy link
Member

Fixes #60

  • Made version mandatory for a custom provider
  • Changed save behavior to prevent error swallowing

mantis-toboggan-md
mantis-toboggan-md approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 9665b76 into rancher:main Jul 22, 2024
@eva-vashkevich eva-vashkevich deleted the iss60-2 branch July 22, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantis-toboggan-md mantis-toboggan-md mantis-toboggan-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when enabling a custom provider without a version
2 participants
@eva-vashkevich @mantis-toboggan-md