Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty string default variable values #73

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Allow empty string default variable values #73

merged 1 commit into from
Jul 25, 2024

Conversation

mantis-toboggan-md
Copy link
Member

Fixes #63

Two components to this fix:

  1. if a variable is set to its default value, assume that value is valid (do not run validators)
  2. if a variable definition's default value is defined, set the value to that by default, even if it is eg an empty string, object or array

eva-vashkevich
eva-vashkevich approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mantis-toboggan-md mantis-toboggan-md merged commit 2be6154 into rancher:main Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eva-vashkevich eva-vashkevich eva-vashkevich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create clusters from a clusterclass - allow empty string default values
2 participants
@mantis-toboggan-md @eva-vashkevich