Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue 3 migration #90

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Vue 3 migration #90

merged 5 commits into from
Nov 18, 2024

Conversation

eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Oct 17, 2024 •
edited
Loading

Updated code to be compatible with Vue 3
Lingering issues:

  1. I wasn't able to replace &::v-deep.wider well and it's giving a compiler warning because v-deep is deprecated.
  2. If you go to view cluster configuration as yaml, it shows an option to see it as Config, which it didn't in 2.10. That view is broken because we agree to not allow viewing config

@eva-vashkevich eva-vashkevich marked this pull request as ready for review November 8, 2024 01:14
@eva-vashkevich eva-vashkevich changed the title Vue3 Vue 3 migration Nov 8, 2024
mantis-toboggan-md
mantis-toboggan-md requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some fairly minor issues with code but overall functionality seems to be good.

I think the two lingering issues you brought up are not blockers and can be addressed in follow up PRs.

pkg/capi/edit/turtles-capi.cattle.io.capiprovider/index.vue Outdated Show resolved Hide resolved
pkg/capi/components/CCVariables/Variable.vue Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@eva-vashkevich eva-vashkevich merged commit fd0cf83 into rancher:main Nov 18, 2024
@eva-vashkevich eva-vashkevich deleted the vue3 branch November 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantis-toboggan-md mantis-toboggan-md mantis-toboggan-md approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eva-vashkevich @mantis-toboggan-md