downloading icons when running make charts

pkg/helm/export.go

@@ -2,7 +2,10 @@ package helm
 
 import (
 	"fmt"
+	"github.com/rancher/charts-build-scripts/pkg/icons"
+	"helm.sh/helm/v3/pkg/chartutil"
 	"math"
+	"net/url"
 	"os"
 	"path/filepath"
 
@@ -33,6 +36,24 @@ func ExportHelmChart(rootFs, fs billy.Filesystem, helmChartPath string, packageV
 	if err != nil {
 		return fmt.Errorf("could not load Helm chart: %s", err)
 	}
+	//checking if icon is pointing to a valid http/https url
+	u, err := url.Parse(chart.Metadata.Icon)
+	if err == nil && (u.Scheme == "http" || u.Scheme == "https") {
+		logrus.Infof("Chart icon is pointing to a remote url. Downloading it...")
+		// download icon and change the icon property to point to it
+		p, err := icons.Download(rootFs, chart.Metadata)
+		if err == nil { // managed to download the icon and save it locally
+			chart.Metadata.Icon = fmt.Sprintf("file://%s", p)
+		} else {
+			logrus.Errorf("failed to download icon for chart %s, err: %s", chart.Name(), err)
+		}
+	}
+
+	chartYamlPath := fmt.Sprintf("%s/Chart.yaml", absHelmChartPath)
+	err = chartutil.SaveChartfile(chartYamlPath, chart.Metadata)
+	if err != nil {
+		return err
+	}
 	if err := chart.Validate(); err != nil {
 		return fmt.Errorf("failed while trying to validate Helm chart: %s", err)
 	}

pkg/icons/icons.go

@@ -0,0 +1,44 @@
+package icons
+
+import (
+	"fmt"
+	"github.com/rancher/charts-build-scripts/pkg/path"
+	"io"
+	"mime"
+	"net/http"
+
+	"github.com/go-git/go-billy/v5"
+	"github.com/sirupsen/logrus"
+	"helm.sh/helm/v3/pkg/chart"
+)
+
+// Download receives a chart metadata and the filesystem pointing to the root of the project.
+// From the metadata, gets the icon and name of the chart.
+// It downloads the icon, infers the type using the content-type header from the response
+// and saves the file locally to path.RepositoryLogosDir using the name of the chart as the file name.
+func Download(rootFs billy.Filesystem, metadata *chart.Metadata) (string, error) {
+	icon, err := http.Get(metadata.Icon)
+	if err != nil {
+		logrus.Errorf(err.Error())
+		return "", fmt.Errorf("err: %w", err)
+	}
+
+	byType, err := mime.ExtensionsByType(icon.Header.Get("Content-Type"))
+	if err != nil || len(byType) == 0 || icon.StatusCode != http.StatusOK {
+		return "", fmt.Errorf("invalid icon")
+	}
+	path := fmt.Sprintf("%s/%s%s", path.RepositoryLogosDir, metadata.Name, byType[0])
+	create, err := rootFs.Create(path)
+	if err != nil {
+		logrus.Errorf(err.Error())
+		return "", fmt.Errorf("err: %w", err)
+	}
+	defer create.Close()
+	_, err = io.Copy(create, icon.Body)
+	defer icon.Body.Close()
+	if err != nil {
+		logrus.Errorf(err.Error())
+		return "", fmt.Errorf("err: %w", err)
+	}
+	return path, nil
+}

pkg/path/path.go

@@ -46,4 +46,7 @@ const (
 
 	// DefaultCachePath represents the default place to put a cache on pulled values
 	DefaultCachePath = ".charts-build-scripts/.cache"
+
+	// RepositoryLogosDir is a directory on your Staging/Live branch that contains the files with the logos of each chart
+	RepositoryLogosDir = "assets/logos"
 )