Simplify charts-build-scripts tooling
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off on reviewing this. It uses |
|
I confirmed that we can use |
The label that this issue creates does not mean anything to the MAPPS team as it stands. Thus, this workflow has no purpose and should be removed.
adamkpickering
force-pushed
the
simplify-repo-tooling
branch
from
e7d09d6 to
b780ad9
Compare
nicholasSUSE
requested changes
May 27, 2024
nicholasSUSE
approved these changes
May 28, 2024
nicholasSUSE
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that the build process/CI for
charts-build-scriptsis convoluted. I get the sense that it came from a repository template, and many of the features of that template never were needed by this repository. Additionally, it uses Dapper; the last update to the Dapper image was in July 2022, and its use is discouraged by Rancher leadership.Since charts-build-scripts is a plain CLI tool, the tooling doesn't have to be complicated. This PR simplifies it. It uses the go toolchain,
golangci-lint(which the repository already uses), andgoreleaser(which is popular and effective - I've used it in the past) for releases. You can see what a release created bygoreleaserlooks like here.If others on MAPPS disagree with this way of doing things that is totally fine. I know I didn't put this to the team for discussion, so I may have missed something important. I knew that this wouldn't take very long, and it is sometimes easier to critique a working example rather than explaining how something is going to work.
If we merge this, we will need to modify https://github.com/rancher/charts/blob/dev-v2.9/scripts/pull-scripts.
As a bonus, fixes #121.