Validate release charts #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase.yaml pr for releasing charts
|
@rancher/release-team |
|
Ok, I started working on the code the linter pointed, and unit tests started breaking. |
tashima42
requested changes
Sep 6, 2024
tashima42
approved these changes
Sep 11, 2024
nicholasSUSE
force-pushed
the
validate-release-charts
branch
from
25becd5 to
8374739
Compare
tashima42
reviewed
Sep 11, 2024
|
|
||
| func validateRelease(c *cli.Context) { | ||
| if c.Bool("skip") { | ||
| fmt.Println("skipping execution...") |
There was a problem hiding this comment.
skipping here doesn't invalidate the whole point of running this command?
|
Bypassing linter until refactoring of legacy code |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/ecm-distro-tools#469
This solution is only for
Checkpoint: 0, defined in the abovementioned issue.Checkpoint 0: Validate release.yaml
Validation steps: