Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] rancher-monitoring: add ScrapeConfig CRD #3552

Open
wants to merge 2 commits into
base: dev-v2.9
Choose a base branch
from

Conversation

Carlotronics
Copy link

Problem

ScrapeConfig CRD is provided in prometheus charts but missing in rancher monitoring.

Solution

Add ScrapeConfig CRD

Charles Decoux added 2 commits February 23, 2024 12:38
Signed-off-by: Charles Decoux <charles.decoux@diabolocom.com>
Signed-off-by: Charles Decoux <charles.decoux@diabolocom.com>
@Carlotronics Carlotronics requested a review from a team as a code owner March 4, 2024 13:23
Copy link

github-actions bot commented Mar 4, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@Carlotronics Carlotronics changed the title Dev v2.9 crd scrape config [dev-v2.9] rancher-monitoring: add ScrapeConfig CRD Mar 4, 2024
@joshmeranda
Copy link
Contributor

@Carlotronics can you give us some more context? Is this causing issues on your system, point us to the ScrapeConfig definition in kube-prometheus-stack-45.31.1, etc?

Copy link
Contributor

@alexandreLamarre alexandreLamarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs

ScrapeConfig CRD :

Starting with prometheus-operator v0.65.x, one can use the ScrapeConfig CRD to > scrape targets external to the Kubernetes cluster or create scrape configurations that are not possible with the higher level ServiceMonitor/Probe/PodMonitor resources.

Which is supported, since we are using prometheus-operator:v0.65.1, but its absent from the upstream chart we use kube-prometheus-stack-45.31.1, taking a quick glance at the upstream chart commit history, these configs were added in around version 48.x which contains breaking changes to how the chart manages CRDs. So likely these will be supported during our next upgrade of the operator : rancher/rancher#44614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants