[dev-v2.8] fix toleration key #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
joshmeranda
requested changes
Jul 18, 2024
| @@ -1,5 +1,5 @@ | |||
| url: oci://ghcr.io/kube-logging/helm-charts/logging-operator:4.4.0 | |||
| version: 103.1.1 | |||
| version: 103.1.2 | |||
There was a problem hiding this comment.
Can you add -rc1 to the end? We've gone through some versioning issues during releases and the rc makes it all manageable.
joshmeranda
reviewed
Jul 18, 2024
There was a problem hiding this comment.
This change should also be done in its own commit for ease-of-review
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
joshmeranda
approved these changes
Jul 18, 2024
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
nicholasSUSE
pushed a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#7505
Problem
This fix had been previously applied to rancher:dev-v2.7 in this PR. The fix however was lost and re-implemented later into version 2.7. However, dev-v2.8 branched off in the meantime and ended up not having the fix included.