Skip to content

Commit

Permalink
Merge pull request #324 from salasberryfin/tests-switch-havexacteleme…
Browse files Browse the repository at this point in the history
…nts-containelements

test: use gomega's ContainElements
  • Loading branch information
alexander-demicev authored May 16, 2024
2 parents ceab8cc + 6f3f6c3 commit 141f4e0
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions pkg/registration/registration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ func TestInternalFirstMethod(t *testing.T) {
actualAddresses, err := regMethod(nil, tc.rcp, col)
g.Expect(err).NotTo(HaveOccurred())

g.Expect(actualAddresses).To(HaveExactElements(tc.expectedAddresses))
g.Expect(actualAddresses).To(HaveLen(len(tc.expectedAddresses)))
g.Expect(actualAddresses).To(ContainElements(tc.expectedAddresses))
})
}
}
Expand Down Expand Up @@ -172,8 +173,8 @@ func TestInternalOnlyMethod(t *testing.T) {
actualAddresses, err := regMethod(nil, tc.rcp, col)
g.Expect(err).NotTo(HaveOccurred())

g.Expect(actualAddresses).To(HaveExactElements(tc.expectedAddresses))

g.Expect(actualAddresses).To(HaveLen(len(tc.expectedAddresses)))
g.Expect(actualAddresses).To(ContainElements(tc.expectedAddresses))
})
}
}
Expand Down Expand Up @@ -225,8 +226,8 @@ func TestExternalOnlyMethod(t *testing.T) {
actualAddresses, err := regMethod(nil, tc.rcp, col)
g.Expect(err).NotTo(HaveOccurred())

g.Expect(actualAddresses).To(HaveExactElements(tc.expectedAddresses))

g.Expect(len(actualAddresses)).To(Equal(len(tc.expectedAddresses)))
g.Expect(actualAddresses).To(ContainElements(tc.expectedAddresses))
})
}
}
Expand Down Expand Up @@ -276,8 +277,8 @@ func TestAddressMethod(t *testing.T) {

expectedAddresses := []string{"100.100.100.100"}

g.Expect(actualAddresses).To(HaveExactElements(expectedAddresses))

g.Expect(len(actualAddresses)).To(Equal(len(expectedAddresses)))
g.Expect(actualAddresses).To(ContainElements(expectedAddresses))
})
}
}
Expand Down Expand Up @@ -336,8 +337,8 @@ func TestControlPlaneMethod(t *testing.T) {
g.Expect(err).NotTo(HaveOccurred())

expectedAddresses := []string{tc.expectedAddress}
g.Expect(actualAddresses).To(HaveExactElements(expectedAddresses))

g.Expect(len(actualAddresses)).To(Equal(len(expectedAddresses)))
g.Expect(actualAddresses).To(ContainElements(expectedAddresses))
})
}
}
Expand Down Expand Up @@ -376,7 +377,6 @@ func createCluster(name string, cpHost string, cpPort int) *clusterv1.Cluster {
}

return cluster

}

func createMachine(name string, internalIPs []string, externalIPs []string) *clusterv1.Machine {
Expand Down

0 comments on commit 141f4e0

Please sign in to comment.